Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: resolve unused imports if feature flags are disabled #5097

Merged
merged 2 commits into from
Jan 13, 2025
Merged

chore: resolve unused imports if feature flags are disabled #5097

merged 2 commits into from
Jan 13, 2025

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Dec 18, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • This fixes an annoying warning when all the allocator feature flags are set.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs
Copy link
Member

@lemmih ready for review, str8 to /dev/null, more work needed?

@lemmih lemmih marked this pull request as ready for review January 13, 2025 14:41
@lemmih lemmih requested a review from a team as a code owner January 13, 2025 14:41
@lemmih lemmih requested review from LesnyRumcajs and elmattic and removed request for a team January 13, 2025 14:41
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 99c877d Jan 13, 2025
41 checks passed
@LesnyRumcajs LesnyRumcajs deleted the lemmih/resolve-unused-imports branch January 13, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmattic elmattic elmattic approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemmih @LesnyRumcajs @hanabi1224 @elmattic